From b534b0e523b9bb23046c8da98d3c00ddfcd1f06c Mon Sep 17 00:00:00 2001 From: Alexander Werner Date: Mon, 5 Nov 2018 17:01:31 +0100 Subject: [PATCH] Updated validation with loggin --- carom/cli.py | 7 ++++--- carom/config.py | 11 ++++++++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/carom/cli.py b/carom/cli.py index 5ad3de2..cc0bbc6 100644 --- a/carom/cli.py +++ b/carom/cli.py @@ -2,12 +2,13 @@ import click from click_didyoumean import DYMGroup import click_log import logging -logger = logging.getLogger(__name__) -click_log.basic_config(logger) +logger = logging.getLogger('carom.cli') # hard coded module name to support directly called module +root_logger = logging.getLogger('') +click_log.basic_config(root_logger) @click.group(cls=DYMGroup) -@click_log.simple_verbosity_option(logger) +@click_log.simple_verbosity_option(root_logger) def cli(): pass diff --git a/carom/config.py b/carom/config.py index d4cd248..aca661a 100644 --- a/carom/config.py +++ b/carom/config.py @@ -1,10 +1,13 @@ import configparser +import logging -from voluptuous import Schema +from voluptuous import Schema, Error from voluptuous.humanize import validate_with_humanized_errors from carom.const import CONFIG_FILES, DEFAULT_CONFIG +logger = logging.getLogger(__name__) + _parser = configparser.ConfigParser() _parser.read_string(DEFAULT_CONFIG) _parser.read(CONFIG_FILES) @@ -16,6 +19,8 @@ _schema = Schema({ }, }) -config = validate_with_humanized_errors(_parser_dict, _schema) - +try: + config = validate_with_humanized_errors(_parser_dict, _schema) +except Error as e: + logger.error('Failed to validate the configuration:\n{}'.format(e)) __all__ = ('config', )